Skip to content

fix: Added private_key auth for Snowflake #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 5 commits into from
Apr 9, 2022
Merged

fix: Added private_key auth for Snowflake #2508

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22adeab
added private_key auth
sfc-gh-madkins Apr 7, 2022
a8910e7
added private_key auth comment to docs
sfc-gh-madkins Apr 7, 2022
b4e5e34
added private_key auth comment to docs
sfc-gh-madkins Apr 7, 2022
abdc98d
type kwargs to be str -> any
achals Apr 9, 2022
19fac9e
type kwargs to be str -> any and some other fixes
achals Apr 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
added private_key auth 
Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
  • Loading branch information
@sfc-gh-madkins
sfc-gh-madkins committed Apr 7, 2022
commit 22adeabcf8beb6c3e6322b89c44550047453a76b
25 changes: 25 additions & 0 deletions sdk/python/feast/infra/utils/snowflake_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
from typing import Dict, Iterator, List, Optional, Tuple, cast

import pandas as pd
from cryptography.hazmat.backends import default_backend
from cryptography.hazmat.primitives import serialization
from tenacity import (
retry,
retry_if_exception_type,
Expand Down Expand Up @@ -67,6 +69,11 @@ def get_snowflake_conn(config, autocommit=True) -> SnowflakeConnection:
else:
kwargs["schema"] = '"PUBLIC"'

if "private_key" in kwargs:
kwargs["private_key"] = parse_private_key_path(
kwargs["private_key"], kwargs["private_key_passphrase"]
)

try:
conn = snowflake.connector.connect(
application="feast", autocommit=autocommit, **kwargs
Expand Down Expand Up @@ -288,3 +295,21 @@ def chunk_helper(lst: pd.DataFrame, n: int) -> Iterator[Tuple[int, pd.DataFrame]
"""Helper generator to chunk a sequence efficiently with current index like if enumerate was called on sequence."""
for i in range(0, len(lst), n):
yield int(i / n), lst[i : i + n]


def parse_private_key_path(key_path: str, private_key_passphrase: str) -> bytes:

with open(key_path, "rb") as key:
p_key = serialization.load_pem_private_key(
key.read(),
password=private_key_passphrase.encode(),
backend=default_backend(),
)

pkb = p_key.private_bytes(
encoding=serialization.Encoding.DER,
format=serialization.PrivateFormat.PKCS8,
encryption_algorithm=serialization.NoEncryption(),
)
Comment on lines +310 to +314
Copy link
Copy Markdown
Member

@achals achals Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only supported format for the key pair?

Copy link
Copy Markdown
Collaborator Author

@sfc-gh-madkins sfc-gh-madkins Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -- I have add the links to the docs as comments.


return pkb