Skip to content

fix: Added private_key auth for Snowflake #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 5 commits into from
Apr 9, 2022
Merged

fix: Added private_key auth for Snowflake #2508

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22adeab
added private_key auth
sfc-gh-madkins Apr 7, 2022
a8910e7
added private_key auth comment to docs
sfc-gh-madkins Apr 7, 2022
b4e5e34
added private_key auth comment to docs
sfc-gh-madkins Apr 7, 2022
abdc98d
type kwargs to be str -> any
achals Apr 9, 2022
19fac9e
type kwargs to be str -> any and some other fixes
achals Apr 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
type kwargs to be str -> any and some other fixes 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Apr 9, 2022
commit 19fac9ebd61b40812a51c142ac922aa4ff6f05e4
10 changes: 5 additions & 5 deletions sdk/python/feast/infra/utils/snowflake_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import string
from logging import getLogger
from tempfile import TemporaryDirectory
from typing import Dict, Iterator, List, Optional, Tuple, cast, Any
from typing import Any, Dict, Iterator, List, Optional, Tuple, cast

import pandas as pd
from cryptography.hazmat.backends import default_backend
Expand Down Expand Up @@ -42,8 +42,8 @@ def execute_snowflake_statement(conn: SnowflakeConnection, query) -> SnowflakeCu


def get_snowflake_conn(config, autocommit=True) -> SnowflakeConnection:
if config.type == "snowflake.offline":
config_header = "connections.feast_offline_store"
assert config.type == "snowflake.offline"
config_header = "connections.feast_offline_store"

config_dict = dict(config)

Expand All @@ -68,8 +68,8 @@ def get_snowflake_conn(config, autocommit=True) -> SnowflakeConnection:
else:
kwargs["schema"] = '"PUBLIC"'

#https://docs.snowflake.com/en/user-guide/python-connector-example.html#using-key-pair-authentication-key-pair-rotation
#https://docs.snowflake.com/en/user-guide/key-pair-auth.html#configuring-key-pair-authentication
# https://docs.snowflake.com/en/user-guide/python-connector-example.html#using-key-pair-authentication-key-pair-rotation
# https://docs.snowflake.com/en/user-guide/key-pair-auth.html#configuring-key-pair-authentication
if "private_key" in kwargs:
kwargs["private_key"] = parse_private_key_path(
kwargs["private_key"], kwargs["private_key_passphrase"]
Expand Down