Skip to content

chore: Add Kevin as an approver and reviewer - #2454

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/add-kev
Mar 25, 2022
Merged

chore: Add Kevin as an approver and reviewer#2454
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/add-kev

Conversation

@achals

@achals achals commented Mar 25, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

@kevjumba isn't able to approve or lgtm changes

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Achal Shah <achals@gmail.com>
@achals
achals requested a review from a team as a code owner March 25, 2022 20:57
@achals
achals requested review from tsotnet and removed request for a team March 25, 2022 20:57
Comment thread go/internal/feast/featurestore.go

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

codecov-commenter commented Mar 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2454 (9daa51f) into master (f202f92) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2454      +/-   ##
==========================================
- Coverage   84.82%   84.72%   -0.10%     
==========================================
  Files         126      126              
  Lines       10798    10798              
==========================================
- Hits         9159     9149      -10     
- Misses       1639     1649      +10     
Flag Coverage Δ
integrationtests 74.71% <ø> (-0.32%) ⬇️
unittests 58.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
...ython/feast/embedded_go/online_features_service.py 95.08% <0.00%> (-1.64%) ⬇️
.../integration/online_store/test_universal_online.py 93.03% <0.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f202f92...9daa51f. Read the comment docs.

@feast-ci-bot
feast-ci-bot merged commit f7bd5d5 into feast-dev:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants