Skip to content

chore: Add Kevin as an approver and reviewer #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Mar 25, 2022
Merged

chore: Add Kevin as an approver and reviewer #2454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ approvers:
- felixwang9817
- mavysavydav
- MattDelac
- kevjumba
reviewers:
- woop
- tsotnet
Expand All @@ -18,3 +19,4 @@ reviewers:
- felixwang9817
- mavysavydav
- MattDelac
- kevjumba
2 changes: 1 addition & 1 deletion go/internal/feast/featurestore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ func groupFeatureRefs(requestedFeatureViews []*featureViewAndRefs,
joinKeys := make([]string, 0)
fv := featuresAndView.view
featureNames := featuresAndView.featureRefs
for entity, _ := range fv.entities {
for entity := range fv.entities {
Comment thread
achals marked this conversation as resolved.
joinKeys = append(joinKeys, entityNameToJoinKeyMap[entity])
}

Expand Down