Skip to content

chore: Add support for push sources in feature views #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 6 commits into from
Mar 25, 2022
Merged

chore: Add support for push sources in feature views #2452

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1756a14
chore: Add support for push sources in feature views
achals Mar 25, 2022
fbea6a8
merge from master
achals Mar 25, 2022
1840abb
fix test
achals Mar 25, 2022
5002ef0
cr
achals Mar 25, 2022
8bf8b84
Add universal test
achals Mar 25, 2022
0a42623
cr
achals Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Mar 25, 2022
commit 1840abb9de10b00cbb8487b9699c198891b751f4
4 changes: 2 additions & 2 deletions sdk/python/tests/integration/registration/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ def test_universal_cli(environment: Environment):
cwd=repo_path,
)
assertpy.assert_that(result.returncode).is_equal_to(0)
assertpy.assert_that(fs.list_feature_views()).is_length(3)
assertpy.assert_that(fs.list_feature_views()).is_length(4)
result = runner.run(
["data-sources", "describe", "customer_profile_source"], cwd=repo_path,
)
assertpy.assert_that(result.returncode).is_equal_to(0)
assertpy.assert_that(fs.list_data_sources()).is_length(3)
assertpy.assert_that(fs.list_data_sources()).is_length(4)

# entity & feature view describe commands should fail when objects don't exist
result = runner.run(["entities", "describe", "foo"], cwd=repo_path)
Expand Down