Skip to content

chore: Add support for push sources in feature views#2452

Merged
feast-ci-bot merged 6 commits intofeast-dev:masterfrom
achals:achal/fv-source
Mar 25, 2022
Merged

chore: Add support for push sources in feature views#2452
feast-ci-bot merged 6 commits intofeast-dev:masterfrom
achals:achal/fv-source

Conversation

@achals
Copy link
Copy Markdown
Member

@achals achals commented Mar 25, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
Part 2 after #2428

Which issue(s) this PR fixes:

Fixes #

@achals
chore: Add support for push sources in feature views
1756a14 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals requested a review from a team as a code owner March 25, 2022 17:14
@achals achals requested review from kevjumba and removed request for a team March 25, 2022 17:14
achals added 2 commits March 25, 2022 10:23
@achals
merge from master
fbea6a8 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
fix test
1840abb 
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 25, 2022 •
edited
Loading

Codecov Report

Merging #2452 (0a42623) into master (3db4b1b) will increase coverage by 0.12%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##           master    #2452      +/-   ##
==========================================
+ Coverage   84.72%   84.85%   +0.12%     
==========================================
  Files         126      127       +1     
  Lines       10798    10833      +35     
==========================================
+ Hits         9149     9192      +43     
+ Misses       1649     1641       -8
Flag Coverage Δ
integrationtests 75.15% <91.04%> (+0.19%) ⬆️
unittests 58.31% <55.88%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 55.05% <33.33%> (-0.34%) ⬇️
sdk/python/feast/feature_view.py 91.47% <77.77%> (-1.22%) ⬇️
sdk/python/feast/data_source.py 66.98% <85.71%> (+1.28%) ⬆️
sdk/python/feast/__init__.py 90.90% <100.00%> (ø)
sdk/python/feast/feature_store.py 91.65% <100.00%> (+0.09%) ⬆️
...ts/integration/feature_repos/repo_configuration.py 96.10% <100.00%> (+0.02%) ⬆️
...tegration/feature_repos/universal/feature_views.py 84.61% <100.00%> (+0.74%) ⬆️
...gration/online_store/test_push_online_retrieval.py 100.00% <100.00%> (ø)
.../python/tests/integration/registration/test_cli.py 98.72% <100.00%> (ø)
sdk/python/tests/unit/test_data_sources.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db4b1b...0a42623. Read the comment docs.

felixwang9817
felixwang9817 requested changes Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall - at some point we should add (a) docs for PushSource and (b) deprecation warning for write_to_online_store, happy for those to be in future PR - up to you

achals added 2 commits March 25, 2022 12:07
@achals
cr
5002ef0 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Add universal test
8bf8b84 
Signed-off-by: Achal Shah <achals@gmail.com>
felixwang9817
felixwang9817 reviewed Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more nits

@achals
cr
0a42623 
Signed-off-by: Achal Shah <achals@gmail.com>
felixwang9817
felixwang9817 approved these changes Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Mar 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 24470b6 into feast-dev:master Mar 25, 2022
@achals achals deleted the achal/fv-source branch March 25, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

@kevjumba kevjumba Awaiting requested review from kevjumba kevjumba was automatically assigned from feast-dev/maintainers

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achals @codecov-commenter @feast-ci-bot @felixwang9817