Skip to content

Feast plan clean up #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 8 commits into from
Jan 30, 2022
Merged

Feast plan clean up #2256

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
817a8da
Run validation and inference on views and entities during plan
felixwang9817 Jan 29, 2022
22e3eec
Do not log objects that are unchanged
felixwang9817 Jan 29, 2022
6afdeba
Rename Fco to FeastObject
felixwang9817 Jan 29, 2022
8f5d9ef
Remove useless method
felixwang9817 Jan 29, 2022
4d5eb6b
Lint
felixwang9817 Jan 29, 2022
bc720f5
Always initialize registry during feature store initialization
felixwang9817 Jan 29, 2022
4e93615
Fix usage test
felixwang9817 Jan 29, 2022
335e8db
Remove print statements
felixwang9817 Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Jan 29, 2022
commit 4d5eb6bef2a245744346cd3cecdad52db9b4745f
3 changes: 1 addition & 2 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
from feast import feature_server, flags, flags_helper, utils
from feast.base_feature_view import BaseFeatureView
from feast.diff.infra_diff import InfraDiff, diff_infra_protos
from feast.diff.property_diff import TransitionType
from feast.diff.registry_diff import RegistryDiff, apply_diff_to_registry, diff_between
from feast.entity import Entity
from feast.errors import (
Expand Down Expand Up @@ -75,7 +74,7 @@
)
from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
from feast.protos.feast.types.Value_pb2 import RepeatedValue, Value
from feast.registry import FeastObjectType, Registry
from feast.registry import Registry
from feast.repo_config import RepoConfig, load_repo_config
from feast.repo_contents import RepoContents
from feast.request_feature_view import RequestFeatureView
Expand Down