Skip to content

Feast plan clean up #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 8 commits into from
Jan 30, 2022
Merged

Feast plan clean up #2256

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
817a8da
Run validation and inference on views and entities during plan
felixwang9817 Jan 29, 2022
22e3eec
Do not log objects that are unchanged
felixwang9817 Jan 29, 2022
6afdeba
Rename Fco to FeastObject
felixwang9817 Jan 29, 2022
8f5d9ef
Remove useless method
felixwang9817 Jan 29, 2022
4d5eb6b
Lint
felixwang9817 Jan 29, 2022
bc720f5
Always initialize registry during feature store initialization
felixwang9817 Jan 29, 2022
4e93615
Fix usage test
felixwang9817 Jan 29, 2022
335e8db
Remove print statements
felixwang9817 Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not log objects that are unchanged 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Jan 29, 2022
commit 22e3eec7e100332c457d1049ea9ccc75473dfa07
8 changes: 8 additions & 0 deletions sdk/python/feast/diff/FcoDiff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,20 @@ def to_string(self):
for fco_diff in self.fco_diffs:
if fco_diff.name == DUMMY_ENTITY_NAME:
continue
if fco_diff.transition_type == TransitionType.UNCHANGED:
continue
action, color = message_action_map[fco_diff.transition_type]
log_string += f"{action} {fco_diff.fco_type.value} {Style.BRIGHT + color}{fco_diff.name}{Style.RESET_ALL}\n"
if fco_diff.transition_type == TransitionType.UPDATE:
for _p in fco_diff.fco_property_diffs:
log_string += f"\t{_p.property_name}: {Style.BRIGHT + color}{_p.val_existing}{Style.RESET_ALL} -> {Style.BRIGHT + Fore.LIGHTGREEN_EX}{_p.val_declared}{Style.RESET_ALL}\n"

log_string = (
f"{Style.BRIGHT + Fore.LIGHTBLUE_EX}No changes to registry"
if not log_string
else log_string
)

return log_string


Expand Down
8 changes: 8 additions & 0 deletions sdk/python/feast/diff/infra_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,20 @@ def to_string(self):
TransitionType.UPDATE: ("Updated", Fore.YELLOW),
}
for infra_object_diff in self.infra_object_diffs:
if infra_object_diff.transition_type == TransitionType.UNCHANGED:
continue
action, color = message_action_map[infra_object_diff.transition_type]
log_string += f"{action} {infra_object_diff.infra_object_type} {Style.BRIGHT + color}{infra_object_diff.name}{Style.RESET_ALL}\n"
if infra_object_diff.transition_type == TransitionType.UPDATE:
for _p in infra_object_diff.infra_object_property_diffs:
log_string += f"\t{_p.property_name}: {Style.BRIGHT + color}{_p.val_existing}{Style.RESET_ALL} -> {Style.BRIGHT + Fore.LIGHTGREEN_EX}{_p.val_declared}{Style.RESET_ALL}\n"

log_string = (
f"{Style.BRIGHT + Fore.LIGHTBLUE_EX}No changes to infrastructure"
if not log_string
else log_string
)

return log_string


Expand Down