Skip to content

Use correct name when deleting dynamo table - #2154

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pyalex:fix-dynamo-deletion
Dec 16, 2021
Merged

Use correct name when deleting dynamo table#2154
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pyalex:fix-dynamo-deletion

Conversation

@pyalex

@pyalex pyalex commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

Signed-off-by: pyalex moskalenko.alexey@gmail.com

What this PR does / why we need it:

When deleting dynamo table project name is not used, that leads to leakage in dynamo tables.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants