Implement rollback API for providers - #2149
Conversation
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: judahrand The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @judahrand. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The AWS failures make it a bit tricky to tell that this is working as intended. I'm not sure how to proceed on that front. |
|
@judahrand thanks for this PR! we believe we've fixed most of the issues with AWS integration tests (we increased the size of our Redshift cluster for tests and found a bug here that kept leaking Dynamo tables), so we're hoping the tests are fine going forward (we still expect occasional leakages until this issue has been resolved, but they should be very manageable) as for the rollback API, we're still considering whether it should be supported, but for now since tests should be fine, let's put a hold on this PR! |
What this PR does / why we need it:
Addresses the issue mentioned. This is very much a first pass solution so keen for any and all feedback.
Which issue(s) this PR fixes:
Fixes #2116
Does this PR introduce a user-facing change?: