Skip to content

Infer features for on demand feature views, support multiple output features - #1845

Merged
feast-ci-bot merged 13 commits into
feast-dev:masterfrom
achals:achal/feature-inference-really
Sep 9, 2021
Merged

Infer features for on demand feature views, support multiple output features#1845
feast-ci-bot merged 13 commits into
feast-dev:masterfrom
achals:achal/feature-inference-really

Conversation

@achals

@achals achals commented Sep 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Infer features for on demand feature views, support multiple output features

@achals
Infer features for on demand feature views
8e5490f 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
achals requested review from a team, tsotnet and woop as code owners September 8, 2021 06:02
@codecov-commenter

codecov-commenter commented Sep 8, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1845 (bb914b6) into master (b509092) will increase coverage by 0.32%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
+ Coverage   84.52%   84.84%   +0.32%     
==========================================
  Files          90       91       +1     
  Lines        6837     6924      +87     
==========================================
+ Hits         5779     5875      +96     
+ Misses       1058     1049       -9
Flag Coverage Δ
integrationtests 84.77% <95.83%> (+0.32%) ⬆️
unittests 63.41% <40.83%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fline_store/test_universal_historical_retrieval.py 100.00% <ø> (ø)
sdk/python/feast/type_map.py 81.25% <62.50%> (-1.61%) ⬇️
sdk/python/feast/on_demand_feature_view.py 91.78% <96.00%> (+2.19%) ⬆️
sdk/python/feast/feature_store.py 93.76% <97.14%> (+0.62%) ⬆️
sdk/python/feast/errors.py 69.15% <100.00%> (+1.19%) ⬆️
sdk/python/feast/feature.py 75.00% <100.00%> (ø)
sdk/python/feast/infra/offline_stores/file.py 97.43% <100.00%> (ø)
...python/feast/infra/offline_stores/offline_utils.py 91.20% <100.00%> (+0.09%) ⬆️
sdk/python/feast/infra/provider.py 89.25% <100.00%> (+0.27%) ⬆️
...tegration/feature_repos/universal/feature_views.py 96.00% <100.00%> (+0.16%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b509092...bb914b6. Read the comment docs.

@achals
Update all feature_refs
a01e8bb 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
make format
8c3c625 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Refactor
6e9f476 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
remove imports
3fd5c47 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
remove a wierd union in the return type for _group_refs
6a6fa08 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals changed the title Infer features for on demand feature views Infer features for on demand feature views, support multiple output features Sep 9, 2021
@adchia adchia self-assigned this Sep 9, 2021
@achals
achals requested review from adchia and removed request for tsotnet and woop September 9, 2021 16:48
@achals
merge from master
984d516 
Signed-off-by: Achal Shah <achals@gmail.com>
codyjlin
codyjlin reviewed Sep 9, 2021
View reviewed changes
Comment thread sdk/python/feast/feature_store.py Outdated
@achals
use self._list
445e984 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
build template
955b92b 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
fix bug and remove prints
3e909a2 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Remove more prints
729e77d 
Signed-off-by: Achal Shah <achals@gmail.com>
adchia
adchia approved these changes Sep 9, 2021
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks like there is some weird rebasing that happened re the README

Comment thread sdk/python/feast/type_map.py Outdated
ValueType.DOUBLE: "float",
ValueType.BYTES: "bytes",
ValueType.BOOL: "bool",
ValueType.UNIX_TIMESTAMP: "Timestamp",

@adchia adchia Sep 9, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a pandas type? couldn't find documentation for Timestamp

@achals achals Sep 9, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - I think this is a protobuf type. Fixing.

Comment thread sdk/python/feast/feature_store.py Outdated
odfv_feature_refs = defaultdict(list)
for feature_ref in feature_refs:
view_name, feature_name = (
feature_ref.split(":")[0],

@adchia adchia Sep 9, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: view_name, feature_name = feature_ref.split(":") I tihnk should work

@achals achals Sep 9, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@achals

achals commented Sep 9, 2021

Copy link
Copy Markdown
Member Author

Nice! Looks like there is some weird rebasing that happened re the README

This is a precommit hook that ran on the README. my guess is that it was added after the README changes were committed and it wasn't run on all existing files.

@achals
CR updates
bb914b6 
Signed-off-by: Achal Shah <achals@gmail.com>
adchia
adchia approved these changes Sep 9, 2021
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Sep 9, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals achals added kind/feature New feature or request and removed needs-kind labels Sep 9, 2021
@feast-ci-bot
feast-ci-bot merged commit 2d52ce7 into feast-dev:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyjlin codyjlin codyjlin left review comments
@adchia adchia adchia approved these changes

Assignees

@adchia adchia

Labels

approved kind/feature New feature or request lgtm release-note size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@achals @codecov-commenter @feast-ci-bot @adchia @codyjlin