CR updates

achals · achals · commit bb914b643fef · 2021-09-09T14:02:31.000-07:00
Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -892,10 +892,7 @@ def _augment_response_with_on_demand_transforms(
 
         odfv_feature_refs = defaultdict(list)
         for feature_ref in feature_refs:
-            view_name, feature_name = (
-                feature_ref.split(":")[0],
-                feature_ref.split(":")[1],
-            )
+            view_name, feature_name = feature_ref.split(":")
             if view_name in all_odfv_feature_names:
                 odfv_feature_refs[view_name].append(feature_name)
 
diff --git a/sdk/python/feast/type_map.py b/sdk/python/feast/type_map.py
@@ -81,7 +81,7 @@ def feast_value_type_to_pandas_type(value_type: ValueType) -> Any:
         ValueType.DOUBLE: "float",
         ValueType.BYTES: "bytes",
         ValueType.BOOL: "bool",
-        ValueType.UNIX_TIMESTAMP: "Timestamp",
+        ValueType.UNIX_TIMESTAMP: "datetime",
     }
     if value_type in value_type_to_pandas_type:
         return value_type_to_pandas_type[value_type]

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ def feast_value_type_to_pandas_type(value_type: ValueType) -> Any:`
`81`	`81`	`ValueType.DOUBLE: "float",`
`82`	`82`	`ValueType.BYTES: "bytes",`
`83`	`83`	`ValueType.BOOL: "bool",`
`84`		`- ValueType.UNIX_TIMESTAMP: "Timestamp",`
	`84`	`+ ValueType.UNIX_TIMESTAMP: "datetime",`
`85`	`85`	`}`
`86`	`86`	`if value_type in value_type_to_pandas_type:`
`87`	`87`	`return value_type_to_pandas_type[value_type]`