Skip to content

Add streaming sources to the FeatureView API #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 9 commits into from
Jun 28, 2021
Merged

Add streaming sources to the FeatureView API #1664

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2e0892b
Add a streaming source to the FeatureView API
achals Jun 23, 2021
4096979
remove stuff from rebase
achals Jun 23, 2021
286b619
make format
achals Jun 23, 2021
df447b3
Update protos
achals Jun 25, 2021
62a6431
lint
achals Jun 25, 2021
ac1dbfa
format
achals Jun 25, 2021
81d6d41
CR
achals Jun 28, 2021
6d40063
fix test
achals Jun 28, 2021
dcfa59a
lint
achals Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CR 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Jun 28, 2021
commit 81d6d41d38d2fc35e428f97115b81d0f1d480f8c
1 change: 1 addition & 0 deletions protos/feast/core/FeatureView.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ message FeatureViewSpec {

// Batch/Offline DataSource where this view can retrieve offline feature data.
DataSource batch_source = 7;
// Streaming DataSource from where this view can consume "online" feature data.
DataSource stream_source = 9;
Comment thread
woop marked this conversation as resolved.
Outdated

// Whether these features should be served online or not
Expand Down
3 changes: 3 additions & 0 deletions sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,9 @@ def __init__(
)

def __eq__(self, other):
if other is None:
return False

if not isinstance(other, KinesisSource):
raise TypeError(
"Comparisons should only involve KinesisSource class objects."
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def from_proto(cls, feature_view_proto: FeatureViewProto):
batch_source=_input,
stream_source=(
feature_view_proto.spec.stream_source
if feature_view_proto.spec.stream_source is None
if feature_view_proto.spec.stream_source is not None
else None
),
)
Expand Down