Skip to content

Add streaming sources to the FeatureView API #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 9 commits into from
Jun 28, 2021
Merged

Add streaming sources to the FeatureView API #1664

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2e0892b
Add a streaming source to the FeatureView API
achals Jun 23, 2021
4096979
remove stuff from rebase
achals Jun 23, 2021
286b619
make format
achals Jun 23, 2021
df447b3
Update protos
achals Jun 25, 2021
62a6431
lint
achals Jun 25, 2021
ac1dbfa
format
achals Jun 25, 2021
81d6d41
CR
achals Jun 28, 2021
6d40063
fix test
achals Jun 28, 2021
dcfa59a
lint
achals Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove stuff from rebase 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Jun 28, 2021
commit 40969793c6fa4b7b326b4095f8b542cacda6ef94
24 changes: 0 additions & 24 deletions sdk/python/feast/feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,30 +72,6 @@ def __init__(
assert input or batch_source
_input = input or batch_source

if not features:
features = [] # to handle python's mutable default arguments
columns_to_exclude = {
_input.event_timestamp_column,
_input.created_timestamp_column,
} | set(entities)

for col_name, col_datatype in _input.get_table_column_names_and_types():
if col_name not in columns_to_exclude and not re.match(
"^__|__$", col_name
):
features.append(
Feature(
col_name,
_input.source_datatype_to_feast_value_type()(col_datatype),
)
)

if not features:
raise ValueError(
f"Could not infer Features for the FeatureView named {name}."
f" Please specify Features explicitly for this FeatureView."
)

cols = [entity for entity in entities] + [feat.name for feat in features]
for col in cols:
if _input.field_mapping is not None and col in _input.field_mapping.keys():
Expand Down