add offlinestore config type to test

Signed-off-by: lblokhin <lenin133@yandex.ru>
feast-dev · feast-ci-bot · Jul 3, 2021 · Apr 27, 2021 · Apr 27, 2021 · May 4, 2021
commit db616c46a3882327990811dbcd00df0bec6dbfe5
diff --git a/sdk/python/feast/infra/aws_dynamodb_provider.py b/sdk/python/feast/infra/aws_dynamodb_provider.py
@@ -12,7 +12,7 @@
 from feast.entity import Entity
 from feast.feature_view import FeatureView
 from feast.infra.key_encoding_utils import serialize_entity_key
-from feast.infra.offline_stores.helpers import get_offline_store_from_sources
+from feast.infra.offline_stores.helpers import get_offline_store_from_config
 from feast.infra.provider import (
     Provider,
     RetrievalJob,
@@ -48,6 +48,8 @@ def __init__(self, config: RepoConfig):
         else:
             self.region_name = os.environ.get("AWS_DEFAULT_REGION", "us-west-2")
             os.environ["AWS_DEFAULT_REGION"] = self.region_name
+        assert config.offline_store is not None
+        self.offline_store = get_offline_store_from_config(config.offline_store)
 
     def _initialize_dynamodb(self):
         return boto3.resource("dynamodb", region_name=self.region_name)
@@ -184,8 +186,7 @@ def materialize_single_feature_view(
         start_date = utils.make_tzaware(start_date)
         end_date = utils.make_tzaware(end_date)
 
-        offline_store = get_offline_store_from_sources([feature_view.input])
-        table = offline_store.pull_latest_from_table_or_query(
+        table = self.offline_store.pull_latest_from_table_or_query(
             data_source=feature_view.input,
             join_key_columns=join_key_columns,
             feature_name_columns=feature_name_columns,

@@ -224,6 +224,8 @@ def _validate_offline_store_config(cls, values):
         if "type" not in values["offline_store"]:
             if values["provider"] == "local" or values["provider"] == "redis":
                 values["offline_store"]["type"] = "file"
+            elif values["provider"] == "aws_dynamodb":
+                values["offline_store"]["type"] = "bigquery"
             elif values["provider"] == "gcp":
                 values["offline_store"]["type"] = "bigquery"
 

@@ -27,10 +27,12 @@ def test_basic() -> None:
         repo_config.write_text(
             dedent(
                 f"""
-        project: {project_id}
-        registry: {data_path / "registry.db"}
-        provider: aws_dynamodb
-        """
+            project: {project_id}
+            registry: {data_path / "registry.db"}
+            provider: aws_dynamodb
+            offline_store:
+                type: file
+            """
             )
         )