review requested changes

Signed-off-by: lblokhin <lenin133@yandex.ru>
feast-dev · feast-ci-bot · Jul 3, 2021 · Apr 27, 2021 · Apr 27, 2021 · May 4, 2021
commit 7b99cdeb6b99e8d071634aaeecf7311cf4118d5e
diff --git a/Makefile b/Makefile
@@ -41,9 +41,6 @@ install-ci-dependencies: install-python-ci-dependencies install-go-ci-dependenci
 install-python-ci-dependencies:
 	pip install -e "sdk/python[ci]"
 
-install-python-aws-dependencies:
-	pip install -e "sdk/python[aws]"
-
 package-protos:
 	cp -r ${ROOT_DIR}/protos ${ROOT_DIR}/sdk/python/feast/protos
 

@@ -40,24 +40,14 @@ def __init__(self, name, project=None):
             super().__init__(f"Feature table {name} does not exist")
 
 
-class FeatureBucketNotExist(FeastObjectNotFoundException):
-    def __init__(self, bucket, project=None):
-        if project:
-            super().__init__(
-                f"Feature bucket {bucket} does not exist in project {project}"
-            )
-        else:
-            super().__init__(f"Feature bucket {bucket} does not exist")
+class S3RegistryBucketNotExist(FeastObjectNotFoundException):
+    def __init__(self, bucket):
+        super().__init__(f"S3 bucket {bucket} for the Feast registry does not exist")
 
 
-class FeatureBucketForbiddenAccess(FeastObjectNotFoundException):
-    def __init__(self, bucket, project=None):
-        if project:
-            super().__init__(
-                f"Private Registry Bucket {bucket} forbidden Access in project {project}"
-            )
-        else:
-            super().__init__(f"Private Registry Bucket {bucket} forbidden Access")
+class S3RegistryBucketForbiddenAccess(FeastObjectNotFoundException):
+    def __init__(self, bucket):
+        super().__init__(f"S3 bucket {bucket} for the Feast registry can't be accessed")
 
 
 class FeastProviderLoginError(Exception):

@@ -96,9 +96,6 @@ def materialize_single_feature_view(
             created_timestamp_column,
         ) = _get_column_names(feature_view, entities)
 
-        start_date = utils.make_tzaware(start_date)
-        end_date = utils.make_tzaware(end_date)
-
         table = self.offline_store.pull_latest_from_table_or_query(
             data_source=feature_view.input,
             join_key_columns=join_key_columns,
@@ -120,8 +117,6 @@ def materialize_single_feature_view(
                 self.repo_config, feature_view, rows_to_write, lambda x: pbar.update(x)
             )
 
-        feature_view.materialization_intervals.append((start_date, end_date))
-        registry.apply_feature_view(feature_view, project)
 
     @staticmethod
     def get_historical_features(

@@ -145,7 +145,7 @@ def get_provider(config: RepoConfig, repo_path: Path) -> Provider:
 
             return GcpProvider(config)
         elif config.provider == "aws":
-            from feast.infra.aws_provider import AwsProvider
+            from feast.infra.aws import AwsProvider
 
             return AwsProvider(config)
         elif config.provider == "local":

@@ -24,8 +24,8 @@
 from feast.entity import Entity
 from feast.errors import (
     EntityNotFoundException,
-    FeatureBucketForbiddenAccess,
-    FeatureBucketNotExist,
+    S3RegistryBucketForbiddenAccess,
+    S3RegistryBucketNotExist,
     FeatureTableNotFoundException,
     FeatureViewNotFoundException,
 )
@@ -577,9 +577,9 @@ def get_registry_proto(self):
             # If it was a 404 error, then the bucket does not exist.
             error_code = int(e.response["Error"]["Code"])
             if error_code == 404:
-                raise FeatureBucketNotExist(self._bucket)
+                raise S3RegistryBucketNotExist(self._bucket)
             else:
-                raise FeatureBucketForbiddenAccess(self._bucket)
+                raise S3RegistryBucketForbiddenAccess(self._bucket)
 
         try:
             obj = bucket.Object(self._key)

@@ -19,7 +19,7 @@ def bootstrap():
     driver_stats_path = data_path / "driver_stats.parquet"
     driver_df.to_parquet(path=str(driver_stats_path), allow_truncated_timestamps=True)
 
-    example_py_file = repo_path / "driver_example.py"
+    example_py_file = repo_path / "example.py"
     replace_str_in_file(example_py_file, "%PARQUET_PATH%", str(driver_stats_path))
 
 

@@ -1,3 +1,3 @@
 project: my_project
-registry: s3://data/registry.db
+registry: data/registry.db
 provider: aws
@@ -1,7 +1,7 @@
 from datetime import datetime
 
 import pandas as pd
-from driver_example import driver, driver_hourly_stats_view
+from example import driver, driver_hourly_stats_view
 
 from feast import FeatureStore
 
@@ -20,20 +20,17 @@ def main():
     # Select features
     feature_refs = ["driver_hourly_stats:conv_rate", "driver_hourly_stats:acc_rate"]
 
-    #     print()
     print("Loading features into the online store...")
     fs.materialize_incremental(end_date=datetime.now())
 
-    #     print()
     print("Retrieving online features...")
 
-    #     Retrieve features from the online store (Dynamodb)
+    # Retrieve features from the online store (DynamoDB)
     online_features = fs.get_online_features(
         feature_refs=feature_refs,
         entity_rows=[{"driver_id": 1001}, {"driver_id": 1002}],
     ).to_dict()
 
-    print()
     print(pd.DataFrame.from_dict(online_features))