Skip to content

Add project name to feature validation metric - #1264

Merged
pyalex merged 1 commit into
feast-dev:masterfrom
pyalex:validation-metric-project-name
Jan 12, 2021
Merged

Add project name to feature validation metric#1264
pyalex merged 1 commit into
feast-dev:masterfrom
pyalex:validation-metric-project-name

Conversation

@pyalex

@pyalex pyalex commented Jan 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com

What this PR does / why we need it:

Along with feature table name this PR adds project name into feast_feature_validation_check_failed metric.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pyalex
add project name to validation metric
9f1cc54 
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@feast-ci-bot

feast-ci-bot commented Jan 12, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex pyalex added the kind/feature New feature or request label Jan 12, 2021
@pyalex

pyalex commented Jan 12, 2021

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-azure

1 similar comment
@pyalex

pyalex commented Jan 12, 2021

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-azure

@feast-ci-bot

feast-ci-bot commented Jan 12, 2021

Copy link
Copy Markdown
Collaborator

@pyalex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure 9f1cc54 link /test test-end-to-end-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex
pyalex merged commit 9e5c41e into feast-dev:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

No one assigned

Labels

approved kind/feature New feature or request release-note-none size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pyalex @feast-ci-bot