Add project name to feature validation metric (#1264)

pyalex · web-flow · commit 9e5c41eff099 · 2021-01-12T17:25:43.000+08:00
Signed-off-by: Oleksii Moskalenko &lt;moskalenko.alexey@gmail.com&gt;
diff --git a/sdk/python/feast/contrib/validation/ge.py b/sdk/python/feast/contrib/validation/ge.py
@@ -131,6 +131,7 @@ def udf(df: pd.DataFrame) -> pd.Series:
                 value=unexpected_count,
                 tags=[
                     f"feature_table:{os.getenv('FEAST_INGESTION_FEATURE_TABLE', 'unknown')}",
+                    f"project:{os.getenv('FEAST_INGESTION_PROJECT_NAME', 'default')}",
                     f"check:{check_name}",
                 ],
             )
diff --git a/spark/ingestion/src/main/scala/feast/ingestion/StreamingPipeline.scala b/spark/ingestion/src/main/scala/feast/ingestion/StreamingPipeline.scala
@@ -176,7 +176,8 @@ object StreamingPipeline extends BasePipeline with Serializable {
           Map(
             "STATSD_HOST"                   -> c.host,
             "STATSD_PORT"                   -> c.port.toString,
-            "FEAST_INGESTION_FEATURE_TABLE" -> config.featureTable.name
+            "FEAST_INGESTION_FEATURE_TABLE" -> config.featureTable.name,
+            "FEAST_INGESTION_PROJECT_NAME"  -> config.featureTable.project
           )
         case _ => Map.empty[String, String]
       }
diff --git a/tests/e2e/test_validation.py b/tests/e2e/test_validation.py
@@ -200,7 +200,8 @@ def test_validation_reports_metrics(
 
     expected_metrics = [
         (
-            f"feast_feature_validation_check_failed#check:{check_name},feature_table:validation_ge_metrics",
+            f"feast_feature_validation_check_failed#check:{check_name},"
+            f"feature_table:{feature_table.name},project:{feast_client.project}",
             value,
         )
         for check_name, value in unexpected_counts.items()

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ def udf(df: pd.DataFrame) -> pd.Series:`
`131`	`131`	`value=unexpected_count,`
`132`	`132`	`tags=[`
`133`	`133`	`f"feature_table:{os.getenv('FEAST_INGESTION_FEATURE_TABLE', 'unknown')}",`
	`134`	`+ f"project:{os.getenv('FEAST_INGESTION_PROJECT_NAME', 'default')}",`
`134`	`135`	`f"check:{check_name}",`
`135`	`136`	`],`
`136`	`137`	`)`
Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,8 @@ object StreamingPipeline extends BasePipeline with Serializable {`
`176`	`176`	`Map(`
`177`	`177`	`"STATSD_HOST" -> c.host,`
`178`	`178`	`"STATSD_PORT" -> c.port.toString,`
`179`		`- "FEAST_INGESTION_FEATURE_TABLE" -> config.featureTable.name`
	`179`	`+ "FEAST_INGESTION_FEATURE_TABLE" -> config.featureTable.name,`
	`180`	`+ "FEAST_INGESTION_PROJECT_NAME" -> config.featureTable.project`
`180`	`181`	`)`
`181`	`182`	`case _ => Map.empty[String, String]`
`182`	`183`	`}`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,8 @@ def test_validation_reports_metrics(`
`200`	`200`
`201`	`201`	`expected_metrics = [`
`202`	`202`	`(`
`203`		`- f"feast_feature_validation_check_failed#check:{check_name},feature_table:validation_ge_metrics",`
	`203`	`+ f"feast_feature_validation_check_failed#check:{check_name},"`
	`204`	`+ f"feature_table:{feature_table.name},project:{feast_client.project}",`
`204`	`205`	`value,`
`205`	`206`	`)`
`206`	`207`	`for check_name, value in unexpected_counts.items()`