Features are not being ingested due to max age overflow - #1209
Conversation
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pyalex you can just type |
|
@woop sure, I was not aware of this option |
|
@pyalex: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
With big values of max age (like 1 month) stored as Integer (2628000) converting to milliseconds that happens during writing to redis fails with overflow
2628000 * 1000 = -1666967296. Thus all rows are being stored with negative expiry time and being deleted right away.This PR suggests use Long instead of Int for max age. Alternative would be to do
maxAge.toLongbefore converting to milliseconds, but it's very easy to miss that part.Does this PR introduce a user-facing change?: