Skip to content

Features are not being ingested due to max age overflow #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyalex merged 1 commit into from
Dec 2, 2020
Merged

Features are not being ingested due to max age overflow #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spark/ingestion/src/main/scala/feast/ingestion/BatchPipeline.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ object BatchPipeline extends BasePipeline {
.option("namespace", featureTable.name)
.option("project_name", featureTable.project)
.option("timestamp_column", config.source.eventTimestampColumn)
.option("max_age", config.featureTable.maxAge.getOrElse(0))
.option("max_age", config.featureTable.maxAge.getOrElse(0L))
.save()

config.deadLetterPath match {
Expand Down
2 changes: 1 addition & 1 deletion spark/ingestion/src/main/scala/feast/ingestion/IngestionJobConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ case class FeatureTable(
project: String,
entities: Seq[Field],
features: Seq[Field],
maxAge: Option[Int] = None
maxAge: Option[Long] = None
)

case class IngestionJobConfig(
Expand Down
2 changes: 1 addition & 1 deletion spark/ingestion/src/main/scala/feast/ingestion/StreamingPipeline.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ object StreamingPipeline extends BasePipeline with Serializable {
.option("namespace", featureTable.name)
.option("project_name", featureTable.project)
.option("timestamp_column", config.source.eventTimestampColumn)
.option("max_age", config.featureTable.maxAge.getOrElse(0))
.option("max_age", config.featureTable.maxAge.getOrElse(0L))
.save()

config.deadLetterPath match {
Expand Down
4 changes: 2 additions & 2 deletions spark/ingestion/src/main/scala/feast/ingestion/stores/redis/SparkRedisConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ case class SparkRedisConfig(
iteratorGroupingSize: Int = 1000,
timestampPrefix: String = "_ts",
repartitionByEntity: Boolean = true,
maxAge: Int = 0,
maxAge: Long = 0,
expiryPrefix: String = "_ex"
)

Expand All @@ -43,6 +43,6 @@ object SparkRedisConfig {
entityColumns = parameters.getOrElse(ENTITY_COLUMNS, "").split(","),
timestampColumn = parameters.getOrElse(TS_COLUMN, "event_timestamp"),
repartitionByEntity = parameters.getOrElse(ENTITY_REPARTITION, "true") == "true",
maxAge = parameters.get(MAX_AGE).map(_.toInt).getOrElse(0)
maxAge = parameters.get(MAX_AGE).map(_.toLong).getOrElse(0)
)
}
4 changes: 2 additions & 2 deletions spark/ingestion/src/test/scala/feast/ingestion/BatchPipelineIT.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class BatchPipelineIT extends SparkSpec with ForAllTestContainer {
val gen = rowGenerator(startDate, endDate)
val rows = generateDistinctRows(gen, 1000, groupByEntity)
val tempPath = storeAsParquet(sparkSession, rows)
val maxAge = 86400 * 2
val maxAge = 86400L * 30
val configWithMaxAge = config.copy(
source = FileSource(tempPath, Map.empty, "eventTimestamp"),
featureTable = config.featureTable.copy(maxAge = Some(maxAge)),
Expand Down Expand Up @@ -162,7 +162,7 @@ class BatchPipelineIT extends SparkSpec with ForAllTestContainer {

})

val increasedMaxAge = 86400 * 3
val increasedMaxAge = 86400L * 60
val configWithSecondFeatureTable = config.copy(
source = FileSource(tempPath, Map.empty, "eventTimestamp"),
featureTable = config.featureTable.copy(
Expand Down