Skip to content

support redis ssl in feast-serving #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oavdeev merged 2 commits into from
Oct 23, 2020
Merged

support redis ssl in feast-serving #1092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1675ddc
support redis ssl in feast-serving
oavdeev Oct 22, 2020
d720867
maybe fix e2e test deps
oavdeev Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions infra/terraform/aws/helm.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ locals {
config = {
host = module.redis.endpoint
port = 6379
ssl = true
}
subscriptions = [
{
Expand Down
2 changes: 2 additions & 0 deletions protos/feast/core/Store.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ message Store {
int32 max_retries = 4;
// Optional. How often flush data to redis
int32 flush_frequency_seconds = 5;
// Optional. Connect over SSL.
bool ssl = 6;
Comment thread
woop marked this conversation as resolved.
Outdated
}

message BigQueryConfig {
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/requirements-ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ mypy
mypy-protobuf
avro==1.10.0
confluent_kafka
gcsfs
gcsfs
urllib3>=1.25.4
10 changes: 7 additions & 3 deletions .../connectors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,14 @@ private RedisClient(StatefulRedisConnection<byte[], byte[]> connection) {
}

public static RedisClientAdapter create(Map<String, String> config) {

RedisURI uri = RedisURI.create(config.get("host"), Integer.parseInt(config.get("port")));

if (Boolean.parseBoolean(config.get("ssl"))) {
uri.setSsl(true);
}
StatefulRedisConnection<byte[], byte[]> connection =
io.lettuce.core.RedisClient.create(
RedisURI.create(config.get("host"), Integer.parseInt(config.get("port"))))
.connect(new ByteArrayCodec());
io.lettuce.core.RedisClient.create(uri).connect(new ByteArrayCodec());

return new RedisClient(connection);
}
Expand Down