support redis ssl in feast-serving - #1092
Merged
Merged
Conversation
oavdeev
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
October 22, 2020 14:50
Collaborator
Author
|
/kind feature |
oavdeev
force-pushed
the
serving-ssl-redis
branch
from
October 22, 2020 14:50
48aa7f2 to
8db2a7c
Compare
woop
reviewed
Oct 22, 2020
oavdeev
force-pushed
the
serving-ssl-redis
branch
from
October 22, 2020 15:36
8db2a7c to
5f320a9
Compare
Member
|
/lgtm |
woop
approved these changes
Oct 23, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/retest |
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
oavdeev
force-pushed
the
serving-ssl-redis
branch
from
October 23, 2020 05:34
5f320a9 to
1675ddc
Compare
Collaborator
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
oavdeev
force-pushed
the
serving-ssl-redis
branch
from
October 23, 2020 08:02
f7a2307 to
d720867
Compare
Collaborator
|
@oavdeev: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support connecting to redis with ssl in feast-serving
Does this PR introduce a user-facing change?: