Configure jupyter env on AWS via terraform - #1077
Merged
Merged
Conversation
oavdeev
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
October 20, 2020 16:06
oavdeev
force-pushed
the
feast-jupyter-config
branch
from
October 20, 2020 16:15
495a74c to
caf6a65
Compare
Collaborator
Author
|
/kind feature |
Member
|
/lgtm |
woop
approved these changes
Oct 21, 2020
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
oavdeev
force-pushed
the
feast-jupyter-config
branch
from
October 21, 2020 14:08
caf6a65 to
919e78c
Compare
Collaborator
|
New changes are detected. LGTM label has been removed. |
woop
approved these changes
Oct 21, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Automatically provide all the necessary settings on AWS to the jupyter pod via terraform.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: