feast-dev
diff --git a/‎infra/charts/feast/charts/feast-jupyter/README.md‎
Lines changed: 1 addition & 0 deletions b/‎infra/charts/feast/charts/feast-jupyter/README.md‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎infra/charts/feast/charts/feast-jupyter/templates/deployment.yaml‎
Lines changed: 9 additions & 0 deletions b/‎infra/charts/feast/charts/feast-jupyter/templates/deployment.yaml‎
Lines changed: 9 additions & 0 deletions
diff --git a/‎infra/terraform/aws/helm.tf‎
Lines changed: 16 additions & 0 deletions b/‎infra/terraform/aws/helm.tf‎
Lines changed: 16 additions & 0 deletions
@@ -19,3 +19,4 @@ Current chart version is `0.8-SNAPSHOT`
 | image.repository | string | `"gcr.io/kf-feast/feast-jupyter"` | Docker image repository |
 | image.tag | string | `"develop"` | Image tag |
 | replicaCount | int | `1` | Number of pods that will be created |
+| envOverrides | object | `{}` | Extra environment variables to set |
@@ -44,6 +44,15 @@ spec:
             - name: GOOGLE_APPLICATION_CREDENTIALS
               value: /etc/secrets/google/{{ .Values.gcpServiceAccount.existingSecret.key }}
             {{- end }}
+            {{- range $key, $value := .Values.envOverrides }}
+            - name: {{ printf "%s" $key | replace "." "_" | upper | quote }}
+              {{- if eq (kindOf $value) "map" }}
+              valueFrom:
+                {{- toYaml $value | nindent 12}}
+              {{- else }}
+              value: {{ $value | quote }}
+              {{- end }}
+            {{- end }}
           ports:
             - name: http
               containerPort: 8888
 
@@ -77,6 +77,22 @@ locals {
             redis_port = 6379
           }
         }
+
+        "feast-jupyter" = {
+          "envOverrides" = {
+            feast_redis_host                         = module.redis.endpoint
+            feast_redis_port                         = 6379
+            feast_redis_ssl                          = true
+            feast_emr_cluster_id                     = (length(aws_emr_cluster.persistent_cluster) > 0) ? aws_emr_cluster.persistent_cluster[0].id : null
+            feast_emr_region                         = var.region
+            spark_staging_location                   = "s3://${aws_s3_bucket.feast_bucket.id}/artifacts/"
+            feast_emr_log_location                   = "s3://${aws_s3_bucket.feast_bucket.id}/emr-logs/"
+            feast_spark_launcher                     = "emr"
+            feast_historical_feature_output_location = "s3://${aws_s3_bucket.feast_bucket.id}/out/"
+            feast_historical_feature_output_format   = "parquet"
+            kafka_brokers                            = aws_msk_cluster.msk.bootstrap_brokers
+          }
+        }
       }
     }
   }
Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,22 @@ locals {`
`77`	`77`	`redis_port = 6379`
`78`	`78`	`}`
`79`	`79`	`}`
	`80`	`+`
	`81`	`+ "feast-jupyter" = {`
	`82`	`+ "envOverrides" = {`
	`83`	`+ feast_redis_host = module.redis.endpoint`
	`84`	`+ feast_redis_port = 6379`
	`85`	`+ feast_redis_ssl = true`
	`86`	`+ feast_emr_cluster_id = (length(aws_emr_cluster.persistent_cluster) > 0) ? aws_emr_cluster.persistent_cluster[0].id : null`
	`87`	`+ feast_emr_region = var.region`
	`88`	`+ spark_staging_location = "s3://${aws_s3_bucket.feast_bucket.id}/artifacts/"`
	`89`	`+ feast_emr_log_location = "s3://${aws_s3_bucket.feast_bucket.id}/emr-logs/"`
	`90`	`+ feast_spark_launcher = "emr"`
	`91`	`+ feast_historical_feature_output_location = "s3://${aws_s3_bucket.feast_bucket.id}/out/"`
	`92`	`+ feast_historical_feature_output_format = "parquet"`
	`93`	`+ kafka_brokers = aws_msk_cluster.msk.bootstrap_brokers`
	`94`	`+ }`
	`95`	`+ }`
`80`	`96`	`}`
`81`	`97`	`}`
`82`	`98`	`}`