Update serving service to handle new redis encoding - #1038
Merged
feast-ci-bot merged 17 commits intoOct 14, 2020
Conversation
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
October 12, 2020 07:06
terryyylim
force-pushed
the
update-serving-service
branch
from
October 12, 2020 07:07
b35ea28 to
484bc1d
Compare
pyalex
reviewed
Oct 12, 2020
pyalex
reviewed
Oct 12, 2020
terryyylim
force-pushed
the
update-serving-service
branch
from
October 12, 2020 07:30
75d2292 to
150434e
Compare
pyalex
reviewed
Oct 12, 2020
pyalex
reviewed
Oct 12, 2020
pyalex
reviewed
Oct 12, 2020
pyalex
reviewed
Oct 12, 2020
pyalex
reviewed
Oct 12, 2020
pyalex
reviewed
Oct 12, 2020
pyalex
reviewed
Oct 12, 2020
pyalex
reviewed
Oct 12, 2020
terryyylim
force-pushed
the
update-serving-service
branch
6 times, most recently
from
October 13, 2020 04:13
67af5ac to
dbbb10a
Compare
pyalex
reviewed
Oct 13, 2020
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-serving-service
branch
from
October 13, 2020 13:20
dafd584 to
aacce71
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-serving-service
branch
2 times, most recently
from
October 13, 2020 13:45
3290d89 to
7577d30
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-serving-service
branch
from
October 13, 2020 13:47
7577d30 to
ff9b841
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-serving-service
branch
from
October 14, 2020 00:28
42eadab to
53f7c68
Compare
pyalex
reviewed
Oct 14, 2020
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-serving-service
branch
from
October 14, 2020 03:42
1324a8c to
c2ccc39
Compare
pyalex
reviewed
Oct 14, 2020
terryyylim
force-pushed
the
update-serving-service
branch
from
October 14, 2020 04:28
3660f42 to
65187dc
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-serving-service
branch
from
October 14, 2020 04:30
65187dc to
7220482
Compare
pyalex
reviewed
Oct 14, 2020
pyalex
reviewed
Oct 14, 2020
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-serving-service
branch
from
October 14, 2020 04:52
224243d to
f867b52
Compare
pyalex
approved these changes
Oct 14, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As we shift towards supporting the new online serving, online feature retrieval needs to be updated to handle the new Redis encoding. Integration tests for online retrieval is also added in this PR.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: