Skip to content

Commit 53f7c68

Browse files
terryyylimterryyylim
committed
Use immutable map
Signed-off-by: Terence <terencelimxp@gmail.com>
1 parent ff9b841 commit 53f7c68

1 file changed

Lines changed: 17 additions & 62 deletions

File tree

‎serving/src/test/java/feast/serving/it/ServingServiceIT.java‎

Lines changed: 17 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import static org.junit.jupiter.api.Assertions.*;
2020

21+
import com.google.common.collect.ImmutableList;
2122
import com.google.common.collect.ImmutableMap;
2223
import com.google.common.hash.Hashing;
2324
import com.google.protobuf.Timestamp;
@@ -118,12 +119,7 @@ static void globalSetup() {
118119

119120
// Apply FeatureTable
120121
String featureTableName = "rides";
121-
List<String> entities =
122-
new ArrayList<>() {
123-
{
124-
add(entityName);
125-
}
126-
};
122+
ImmutableList<String> entities = ImmutableList.of(entityName);
127123

128124
ServingAPIProto.FeatureReferenceV2 feature1Reference =
129125
DataGenerator.createFeatureReference("rides", "trip_cost");
@@ -213,22 +209,13 @@ public void shouldRegisterAndGetOnlineFeatures() {
213209
// Instantiate EntityRows
214210
GetOnlineFeaturesRequestV2.EntityRow entityRow1 =
215211
DataGenerator.createEntityRow(entityName, DataGenerator.createInt64Value(1), 100);
216-
List<GetOnlineFeaturesRequestV2.EntityRow> entityRows =
217-
new ArrayList<>() {
218-
{
219-
add(entityRow1);
220-
}
221-
};
212+
ImmutableList<GetOnlineFeaturesRequestV2.EntityRow> entityRows = ImmutableList.of(entityRow1);
222213

223214
// Instantiate FeatureReferences
224215
ServingAPIProto.FeatureReferenceV2 feature1Reference =
225216
DataGenerator.createFeatureReference("rides", "trip_cost");
226-
List<ServingAPIProto.FeatureReferenceV2> featureReferences =
227-
new ArrayList<>() {
228-
{
229-
add(feature1Reference);
230-
}
231-
};
217+
ImmutableList<ServingAPIProto.FeatureReferenceV2> featureReferences =
218+
ImmutableList.of(feature1Reference);
232219

233220
// Build GetOnlineFeaturesRequestV2
234221
GetOnlineFeaturesRequestV2 onlineFeatureRequest =
@@ -255,12 +242,8 @@ public void shouldRegisterAndGetOnlineFeatures() {
255242
.putAllFields(expectedValueMap)
256243
.putAllStatuses(expectedStatusMap)
257244
.build();
258-
List<GetOnlineFeaturesResponse.FieldValues> expectedFieldValuesList =
259-
new ArrayList<>() {
260-
{
261-
add(expectedFieldValues);
262-
}
263-
};
245+
ImmutableList<GetOnlineFeaturesResponse.FieldValues> expectedFieldValuesList =
246+
ImmutableList.of(expectedFieldValues);
264247

265248
assertEquals(expectedFieldValuesList, featureResponse.getFieldValuesList());
266249
}
@@ -275,12 +258,7 @@ public void shouldRegisterAndGetOnlineFeaturesWithNotFound() {
275258
// Instantiate EntityRows
276259
GetOnlineFeaturesRequestV2.EntityRow entityRow1 =
277260
DataGenerator.createEntityRow(entityName, DataGenerator.createInt64Value(1), 100);
278-
List<GetOnlineFeaturesRequestV2.EntityRow> entityRows =
279-
new ArrayList<>() {
280-
{
281-
add(entityRow1);
282-
}
283-
};
261+
ImmutableList<GetOnlineFeaturesRequestV2.EntityRow> entityRows = ImmutableList.of(entityRow1);
284262

285263
// Instantiate FeatureReferences
286264
ServingAPIProto.FeatureReferenceV2 featureReference =
@@ -290,14 +268,8 @@ public void shouldRegisterAndGetOnlineFeaturesWithNotFound() {
290268
ServingAPIProto.FeatureReferenceV2 emptyFeatureReference =
291269
DataGenerator.createFeatureReference("rides", "trip_empty");
292270

293-
List<ServingAPIProto.FeatureReferenceV2> featureReferences =
294-
new ArrayList<>() {
295-
{
296-
add(featureReference);
297-
add(notFoundFeatureReference);
298-
add(emptyFeatureReference);
299-
}
300-
};
271+
ImmutableList<ServingAPIProto.FeatureReferenceV2> featureReferences =
272+
ImmutableList.of(featureReference, notFoundFeatureReference, emptyFeatureReference);
301273

302274
// Build GetOnlineFeaturesRequestV2
303275
GetOnlineFeaturesRequestV2 onlineFeatureRequest =
@@ -332,12 +304,8 @@ public void shouldRegisterAndGetOnlineFeaturesWithNotFound() {
332304
.putAllFields(expectedValueMap)
333305
.putAllStatuses(expectedStatusMap)
334306
.build();
335-
List<GetOnlineFeaturesResponse.FieldValues> expectedFieldValuesList =
336-
new ArrayList<>() {
337-
{
338-
add(expectedFieldValues);
339-
}
340-
};
307+
ImmutableList<GetOnlineFeaturesResponse.FieldValues> expectedFieldValuesList =
308+
ImmutableList.of(expectedFieldValues);
341309

342310
assertEquals(expectedFieldValuesList, featureResponse.getFieldValuesList());
343311
}
@@ -351,23 +319,14 @@ public void shouldGetOnlineFeaturesOutsideMaxAge() {
351319
// Instantiate EntityRows
352320
GetOnlineFeaturesRequestV2.EntityRow entityRow1 =
353321
DataGenerator.createEntityRow(entityName, DataGenerator.createInt64Value(1), 7400);
354-
List<GetOnlineFeaturesRequestV2.EntityRow> entityRows =
355-
new ArrayList<>() {
356-
{
357-
add(entityRow1);
358-
}
359-
};
322+
ImmutableList<GetOnlineFeaturesRequestV2.EntityRow> entityRows = ImmutableList.of(entityRow1);
360323

361324
// Instantiate FeatureReferences
362325
ServingAPIProto.FeatureReferenceV2 featureReference =
363326
DataGenerator.createFeatureReference("rides", "trip_cost");
364327

365-
List<ServingAPIProto.FeatureReferenceV2> featureReferences =
366-
new ArrayList<>() {
367-
{
368-
add(featureReference);
369-
}
370-
};
328+
ImmutableList<ServingAPIProto.FeatureReferenceV2> featureReferences =
329+
ImmutableList.of(featureReference);
371330

372331
// Build GetOnlineFeaturesRequestV2
373332
GetOnlineFeaturesRequestV2 onlineFeatureRequest =
@@ -394,12 +353,8 @@ public void shouldGetOnlineFeaturesOutsideMaxAge() {
394353
.putAllFields(expectedValueMap)
395354
.putAllStatuses(expectedStatusMap)
396355
.build();
397-
List<GetOnlineFeaturesResponse.FieldValues> expectedFieldValuesList =
398-
new ArrayList<>() {
399-
{
400-
add(expectedFieldValues);
401-
}
402-
};
356+
ImmutableList<GetOnlineFeaturesResponse.FieldValues> expectedFieldValuesList =
357+
ImmutableList.of(expectedFieldValues);
403358

404359
assertEquals(expectedFieldValuesList, featureResponse.getFieldValuesList());
405360
}

0 commit comments

Comments
 (0)