Skip to content

add redis SSL support to the offline-to-online ingestion job - #1025

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
oavdeev:redis-ssl
Oct 7, 2020
Merged

add redis SSL support to the offline-to-online ingestion job#1025
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
oavdeev:redis-ssl

Conversation

@oavdeev

@oavdeev oavdeev commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Support SSL option for redis connections (aka "encryption in-transit" in AWS ElastiCache) in the Spark job. SSL is already supported by lettuce/springboot out of the box, so this brings Spark to feature parity.

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot

feast-ci-bot commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator

Hi @oavdeev. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oavdeev

oavdeev commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator Author

/assign @woop

@oavdeev

oavdeev commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator Author

/assign @pyalex

@feast-ci-bot

feast-ci-bot commented Oct 7, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oavdeev
add redis SSL support to the offline-to-online ingestion job
bc0e568 
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@pyalex

pyalex commented Oct 7, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

@oavdeev

oavdeev commented Oct 7, 2020

Copy link
Copy Markdown
Collaborator Author

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Oct 7, 2020
@woop

woop commented Oct 7, 2020

Copy link
Copy Markdown
Member

/ok-to-test

@feast-ci-bot
feast-ci-bot merged commit 61133e4 into feast-dev:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyalex pyalex pyalex approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@pyalex pyalex

@woop woop

Labels

approved kind/feature New feature or request lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oavdeev @feast-ci-bot @pyalex @woop