Skip to content

add redis SSL support to the offline-to-online ingestion job #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Oct 7, 2020
Merged

add redis SSL support to the offline-to-online ingestion job #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spark/ingestion/src/main/scala/feast/ingestion/BasePipeline.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ trait BasePipeline {
.setMaster("local")

jobConfig.store match {
case RedisConfig(host, port) =>
case RedisConfig(host, port, ssl) =>
conf
.set("spark.redis.host", host)
.set("spark.redis.port", port.toString)
.set("spark.redis.ssl", ssl.toString)
}

jobConfig.metrics match {
Expand Down
4 changes: 2 additions & 2 deletions spark/ingestion/src/main/scala/feast/ingestion/IngestionJobConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ object Modes extends Enumeration {

abstract class StoreConfig

case class RedisConfig(host: String, port: Int) extends StoreConfig
case class RedisConfig(host: String, port: Int, ssl: Boolean) extends StoreConfig

abstract class MetricConfig

Expand Down Expand Up @@ -84,7 +84,7 @@ case class IngestionJobConfig(
source: Source = null,
startTime: DateTime = DateTime.now(),
endTime: DateTime = DateTime.now(),
store: StoreConfig = RedisConfig("localhost", 6379),
store: StoreConfig = RedisConfig("localhost", 6379, false),
metrics: Option[MetricConfig] = Some(StatsDConfig("localhost", 9125)),
deadLetterPath: Option[String] = None
)