Skip to content

Probe for available port to prevent race condition#1004

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:add-port-probing
Sep 16, 2020
Merged

Probe for available port to prevent race condition#1004
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:add-port-probing

Conversation

@terryyylim

Copy link
Copy Markdown
Member

What this PR does / why we need it:
Current hardcoding port to 45124 causes port conflict.

Which issue(s) this PR fixes:

Fixes #901

Does this PR introduce a user-facing change?:

NONE

@terryyylim

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@terryyylim

Copy link
Copy Markdown
Member Author

/retest

@khorshuheng

Copy link
Copy Markdown
Collaborator

/test test-end-to-end-batch-dataflow

@khorshuheng

Copy link
Copy Markdown
Collaborator

/lgtm

@khorshuheng khorshuheng requested review from khorshuheng and removed request for zhilingc September 16, 2020 06:02
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terryyylim

Copy link
Copy Markdown
Member Author

/retest

@khorshuheng

Copy link
Copy Markdown
Collaborator

/lgtm

@terryyylim

Copy link
Copy Markdown
Member Author

/retest

@feast-ci-bot feast-ci-bot merged commit e35d215 into feast-dev:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition in integration tests

3 participants