Skip to content

Probe for available port to prevent race condition #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Sep 16, 2020
Merged

Probe for available port to prevent race condition #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/test/java/feast/core/auth/CoreServiceAuthenticationIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import org.springframework.boot.test.context.TestConfiguration;
import org.springframework.test.context.DynamicPropertyRegistry;
import org.springframework.test.context.DynamicPropertySource;
import org.springframework.util.SocketUtils;

@SpringBootTest(
properties = {
Expand All @@ -52,7 +53,7 @@ public class CoreServiceAuthenticationIT extends BaseIT {
@Autowired FeastProperties feastProperties;

private static int feast_core_port;
private static int JWKS_PORT = 45124;
private static int JWKS_PORT = SocketUtils.findAvailableTcpPort();

private static JwtHelper jwtHelper = new JwtHelper();

Expand Down
3 changes: 2 additions & 1 deletion core/src/test/java/feast/core/auth/CoreServiceAuthorizationIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
import org.springframework.boot.test.context.TestConfiguration;
import org.springframework.test.context.DynamicPropertyRegistry;
import org.springframework.test.context.DynamicPropertySource;
import org.springframework.util.SocketUtils;
import org.testcontainers.containers.DockerComposeContainer;
import sh.ory.keto.ApiClient;
import sh.ory.keto.ApiException;
Expand All @@ -73,7 +74,7 @@ public class CoreServiceAuthorizationIT extends BaseIT {
private static int KETO_PORT = 4466;
private static int KETO_ADAPTOR_PORT = 8080;
private static int feast_core_port;
private static int JWKS_PORT = 45124;
private static int JWKS_PORT = SocketUtils.findAvailableTcpPort();

private static JwtHelper jwtHelper = new JwtHelper();

Expand Down