Fix py SDK historical retrieval job to chunked dataframe conversion#1002
Merged
Conversation
22ab893 to
f03637d
Compare
f03637d to
a9e7587
Compare
Collaborator
|
/lgtm |
khorshuheng
approved these changes
Sep 16, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a9e7587 to
eb00e27
Compare
Member
Author
|
/retest |
Collaborator
|
/lgtm |
Collaborator
|
/test test-end-to-end-redis-cluster |
Collaborator
|
/test test-end-to-end-batch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Current implementation attempts to append to a Dict instead of List, which throws
AttributeError. Also, last chunk of data which is less than max_chunk_size is not returned.Which issue(s) this PR fixes:
Fixes #944, #948
Does this PR introduce a user-facing change?: