Skip to content

Fix py SDK historical retrieval job to chunked dataframe conversion #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Sep 17, 2020
Merged

Fix py SDK historical retrieval job to chunked dataframe conversion #1002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions sdk/python/feast/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,9 @@ def to_dataframe(
) -> pd.DataFrame:
"""
Wait until a job is done to get an iterable rows of result. This method
will split the response into chunked DataFrame of a specified size to
to be yielded to the instance calling it.
will return the response as a DataFrame.

Args:
max_chunk_size (int):
Maximum number of rows that the DataFrame should contain.

timeout_sec (int):
Max no of seconds to wait until job is done. If "timeout_sec"
is exceeded, an exception will be raised.
Expand Down Expand Up @@ -180,14 +176,14 @@ def to_chunked_dataframe(

# Max chunk size defined by user
for result in self.result(timeout_sec=timeout_sec):
result.append(records)
records.append(result)
if len(records) == max_chunk_size:
df = pd.DataFrame.from_records(records)
records.clear() # Empty records array
yield df

# Handle for last chunk that is < max_chunk_size
if not records:
if records:
yield pd.DataFrame.from_records(records)

def __iter__(self):
Expand Down