Skip to content

rna-transcription: update tests to version 1.0.1#1035

Merged
ilya-khadykin merged 7 commits into
exercism:masterfrom
kishan3:patch-6
Oct 26, 2017
Merged

rna-transcription: update tests to version 1.0.1#1035
ilya-khadykin merged 7 commits into
exercism:masterfrom
kishan3:patch-6

Conversation

@kishan3

@kishan3 kishan3 commented Oct 25, 2017

Copy link
Copy Markdown

Resolves #1020

@ilya-khadykin

ilya-khadykin commented Oct 25, 2017

Copy link
Copy Markdown
Contributor

Build failed due to code style issues:

3.98s$ flake8
./exercises/rna-transcription/rna_transcription_test.py:11:1: W293 blank line contains whitespace
./exercises/rna-transcription/rna_transcription_test.py:13:43: W291 trailing whitespace
The command "flake8" failed and exited with 1 during .
Your build has been stopped.

@ilya-khadykin ilya-khadykin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve code style issues

@cmccandless

Copy link
Copy Markdown
Contributor

To quote @N-Parsons in #1030:

Please use a meaningful title for the PR that includes the exercise name - it makes it much easier to handle pull requests. I would suggest using all-your-base: Update test order and version string". Could you also please add the magic words resolves #1014 to your PR description so that merging list PR closes the corresponding issue.

In your case, the corresponding issue is #1020

@kishan3 kishan3 changed the title Reordered Tests rna-transcription: update tests to version 1.0.1 Oct 26, 2017
@kishan3

kishan3 commented Oct 26, 2017

Copy link
Copy Markdown
Author

Fixed styling issues.

@cmccandless cmccandless left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilya-khadykin ilya-khadykin merged commit 1fb4842 into exercism:master Oct 26, 2017
@ilya-khadykin

Copy link
Copy Markdown
Contributor

Thanks, @kishan3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants