all-your-base: Update test order and version string#1030
Merged
Conversation
N-Parsons
suggested changes
Oct 25, 2017
N-Parsons
left a comment
Contributor
There was a problem hiding this comment.
It looks like the ordering of the tests was altered in the canonical data. Can you please update this test file to reflect those changes?
Also, please use a meaningful title for the PR that includes the exercise name - it makes it much easier to handle pull requests. I would suggest using all-your-base: Update test order and version string". Could you also please add the [magic words](https://help.github.com/articles/closing-issues-using-keywords/) resolves #1014` to your PR description so that merging list PR closes the corresponding issue.
N-Parsons
approved these changes
Oct 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1014