Skip to content

Restructure exercise directories#770

Merged
stkent merged 1 commit into
masterfrom
relocate-example-solutions
Sep 10, 2017
Merged

Restructure exercise directories#770
stkent merged 1 commit into
masterfrom
relocate-example-solutions

Conversation

@stkent
Copy link
Copy Markdown
Contributor

@stkent stkent commented Sep 5, 2017 •
edited
Loading

Moves reference solutions to the new, automatically-ignored .meta directory.

Reviewer Resources:

Track Policies

@stkent stkent force-pushed the relocate-example-solutions branch 2 times, most recently from a692a49 to 2c4fdc0 Compare September 5, 2017 12:23
@stkent
Copy link
Copy Markdown
Contributor Author

stkent commented Sep 5, 2017

Keeping an eye on exercism/discussions#192 before I go any further with this.

@stkent stkent force-pushed the relocate-example-solutions branch 2 times, most recently from fdbd892 to e1c356b Compare September 8, 2017 03:07
@stkent stkent changed the title all-your-base: restructure exercise directory Restructure exercise directories Sep 8, 2017
@stkent
Copy link
Copy Markdown
Contributor Author

stkent commented Sep 8, 2017

Per exercism/discussions#192 (comment):

You could certainly just define a reference solution pattern instead of moving it to .meta. I have a somewhat more than slight preference for putting everything that doesn't get delivered to the user into .meta, since that is pretty easy to understand/explain.

@stkent
Copy link
Copy Markdown
Contributor Author

stkent commented Sep 8, 2017

This is now ready for review :)

FridaTveit
FridaTveit approved these changes Sep 8, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@FridaTveit FridaTveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @stkent! :)

I think some of the documentation will have to be updated because of this. Definitely the contributing guide, and maybe other places? Do you want to do that as part of this PR or should we open a new issue to track it? :)
And your commit message is a bit confusing now since it references all-your-base. It doesn't matter too much but it might cause confusion if we ever need to look through the history :)

@stkent
Copy link
Copy Markdown
Contributor Author

stkent commented Sep 8, 2017

Good catches; I'll fix both in this PR!

@stkent
Restructure exercise directory
54cf4a6 
Reference solution directory was renamed and move to the
always-excluded-from-delivery .meta folder.
@stkent stkent force-pushed the relocate-example-solutions branch from e1c356b to 54cf4a6 Compare September 8, 2017 22:15
Smarticles101
Smarticles101 approved these changes Sep 9, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@Smarticles101 Smarticles101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that you're done with this now, it looks good to me!

@stkent stkent merged commit c4ccaaf into master Sep 10, 2017
@stkent stkent deleted the relocate-example-solutions branch September 10, 2017 01:41
@bmkiefer bmkiefer mentioned this pull request Dec 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Smarticles101 Smarticles101 Smarticles101 approved these changes

@FridaTveit FridaTveit FridaTveit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stkent @Smarticles101 @FridaTveit