Fix journey test#1064
Conversation
Make sure run-journey-test-from-ci doesn't try to run settings.gradle as an exercise.
This reverts commit eb0d5dd.
|
It looks like it's worked? I'll push a revert of the testing commit, and if people agree that it looks like it's worked then this PR can be squashed and merged :) |
|
I'm liking the look of this! I think that it would be great to merge in if it works 🙂 I'd be interested in merging this too, as I've never squashed and merged before and would like to make sure I'm doing it correctly 😃 |
|
LGTM! |
|
Thanks @FridaTveit , and great work everyone! |
|
Wonder why we don't see the |
|
Does it not get pulled in when it is changed? The way that it is written it would lead me to believe that it would cause a CI failure if the build.gradle in the exercises folder changed, similar to how the settings.gradle file was. The most recent change that was merged on the build.gradle suffered from the Github API limit failure that caused the whole test suite to run and complete, here. Which is probably why this didn't come up then. |
|
That was my hypothesis also! |
Attempt to fix #1063. Includes temporary commit to check that it's working (changing something in settings.gradle to make sure the script doesn't try to run settings.gradle like an exercise)
Reviewer Resources:
Track Policies