@marcuslinke should we mix swarm and docker APIs in dockerClient, or create separate objects?

I think we can keep the implementation in the same object, since the swarm API is just a proxy of the docker API, with some very small additions and modifications.
There is also no native docker cli to talk with swarm. And in perspective of maintanace and that swarm is the native way to work with docker clusters we should keep the implementation together.
A list of all currently modifications made by swarm is available at: https://docs.docker.com/swarm/api/swarm-api/.

We currently have a swarm cluster near production ready and the java client works very well with the swarm manager.

@KostyaSha I agree with @fbuecklers in general, but the main point is to have working tests against a running swarm manager. But what about different swarm versions then? Currently we have no concept for testing against different docker engine/swarm versions. Related: #337.

@marcuslinke that what i described in email :) Imho docker-java needs 'its' module with DinD tests.

Related to issue #395

Codecov Report

Merging #383 into master will increase coverage by 0.36%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   61.58%   61.95%   +0.36%     
==========================================
  Files         411      411              
  Lines        8172     8182      +10     
  Branches      530      530              
==========================================
+ Hits         5033     5069      +36     
+ Misses       2838     2813      -25     
+ Partials      301      300       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8902e32...dd9f01d. Read the comment docs.

Any chance to see this pull request in the 3.0.0 release?
We need this small addition to work with our swarm cluster, we must currently always rebase this additions onto the master.

We are also using this changes to use docker-java with swarm cluster. Any change this will be available in the 3.0.0 release?

Hey guys, any chance for this to go in the 3.0?

@marcuslinke maybe we can merge without tests and allow users testing it? :D

3.0.0 was already merged, so 3.1.0 sounds good enough. Hope swarm API become more stable now :)

Please note that with the upcoming Docker 1.12 (remote api 1.24) Swarm will be included. Maybe the api will become more stable then.

See https://docs.docker.com/:

As of v1.12.0-rc1, Engine includes swarm mode container orchestration features.

https://twitter.com/docker/status/744940786899292161
#BIGNEWS: @docker Engine 1.12 now available w/ built-in container #orchestration! goo.gl/fDdLnl #DockerCon

That probably would be good point to start with :) But they banned HostConfig and it would require reviewing API updates and code again :(

Advisory: The Swarm mode feature included in Docker Engine 1.12 is a release candidate feature and might be subject to non backward-compatible changes. Some functionality may change before the feature becomes generally available.

from https://docs.docker.com/engine/swarm/

Live stream is happening!

I have brought my pull request up to date and add some test cases.
It will solve #931 #761 #762 #459 and a few more which are already closed as duplicates.

I have also added an event test for the other node property. Did we wont to merge them? There are of cause the issue with the other case variant and swarm seems to behave differently on inspect and at the events API for the same property values!
Note that the node property only exists in swarm-classic and not in swarm mode. That's why I'm referencing the swarm-mode issues here as well. They are mislabeled ;-).