Issue 761: Inspect command response should include docker swarm node info - #762
Issue 761: Inspect command response should include docker swarm node info#762loganbruns wants to merge 1 commit into
Conversation
…info docker-java#761 It is useful to be able to tell which node a container is running on for various scenarios such as routing traffic dynamically to it. I've tested a change to add this information and will create a PR shortly.
|
@marcuslinke, would it be okay to merge this or equivalent pr? I think this is the last pr keeping us from moving from our patched docker-java build to release builds. Thanks for all the hard work on docker-java. |
|
@KostyaSha is still working on the swarm stuff in its own branch. I guess the main problem is to make swarm features testable. @KostyaSha Any progress on this? Could I help? |
|
@marcuslinke and @KostyaSha, definitely would prefer to get comprehensive swarm support instead. However if that might take a long time then perhaps a fairly small change like this to parse out the additional information from inspect would be helpful in the meantime. Regarding testing. Are you thinking you'll spin up some containers to simulate a small swarm (masters, runners, and consul.) for testing? I guess my question here is if you guys are thinking about some kind of orchestration support like docker-compose for starting a set of related containers? Longer term? |
|
I merged branches, but they fail because of parallel tests. Tests need to be reworked, maybe with registry proxy in travis + dind runs. Either it impossible to do swarm init and etc tests. |
|
@KostyaSha @marcuslinke |
|
@KostyaSha Can this fix be released in 3.0.8/9? |
|
@bklau no, change is binary incompatible |
|
Up-to-date merge request here: #931 |
#761
It is useful to be able to tell which node a container is running on for various scenarios such as routing traffic dynamically to it.
I've tested a change to add this information and will create a PR shortly.
This change is