Repository navigation
Add java16 unix socket support - #1627
Merged
Merged
Conversation
bsideup
reviewed
May 27, 2021
Contributor
Author
|
Good changes! Random aside, is there a reason why the docker-java dependency depends on both netty and jersey, especially when under the https://github.com/docker-java/docker-java/blob/master/docs/transports.md transports page it says apache is the most stable? |
Member
Contributor
Author
|
With the advent of java 17 fast approaching, I'd love to see users of docker-java being able to make use of this. Are there any concerns with getting this merged? |
bsideup
marked this pull request as ready for review
September 9, 2021 08:24
Member
|
@Sineaggi I just applied a bit of polishing, successfully tested locally with JDK16 and will merge in a moment. Thank you! 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And example fix for #1626