Skip to content

Add java16 unix socket support - #1627

Merged
bsideup merged 9 commits into
docker-java:masterfrom
Sineaggi:master
Sep 9, 2021
Merged

bsideup merged 9 commits into
docker-java:masterfrom
Sineaggi:master

Conversation

@Sineaggi

Copy link
Copy Markdown
Contributor

And example fix for #1626

@Sineaggi

Copy link
Copy Markdown
Contributor Author

Good changes! Random aside, is there a reason why the docker-java dependency depends on both netty and jersey, especially when under the https://github.com/docker-java/docker-java/blob/master/docs/transports.md transports page it says apache is the most stable?

@bsideup

bsideup commented May 31, 2021

Copy link
Copy Markdown
Member

@Sineaggi docker-java is a meta package, and, starting with #1237, it is possible to depend on api + core + your transport of choice.

Also, as per the link you shared, any transport that is not marked as "Long term support" most probably will be removed in the next major version.

@Sineaggi

Sineaggi commented Sep 9, 2021

Copy link
Copy Markdown
Contributor Author

With the advent of java 17 fast approaching, I'd love to see users of docker-java being able to make use of this. Are there any concerns with getting this merged?

@bsideup
bsideup marked this pull request as ready for review September 9, 2021 08:24
@bsideup

bsideup commented Sep 9, 2021

Copy link
Copy Markdown
Member

@Sineaggi I just applied a bit of polishing, successfully tested locally with JDK16 and will merge in a moment. Thank you! 👍

@bsideup bsideup added this to the next milestone Sep 9, 2021
@bsideup
bsideup merged commit dd17358 into docker-java:master Sep 9, 2021
@Sineaggi Sineaggi mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants