Revert breaking binary change of CreateContainerCmd - #1225
Merged
KostyaSha merged 2 commits intoJul 22, 2019
Merged
Conversation
The change was introduced in: docker-java@580ea407cc While it is a good change in a long term, 3.1.x should have introduced a deprecation, so that the users have time to update their usages.
This was referenced Jul 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change was introduced in:
580ea407cc
While it is a good change in a long term, 3.1.x should have introduced
a deprecation, so that the users have time to update their usages.
Japicmp of
CreateContainerCmd*report before this change:docker-java_before.pdf
After:
docker-java_after.pdf
This change will finally unblock Testcontainers and let it upgrade to the newer versions of Docker Java
This change is