Skip to content

Bump docker java 3.1.4 - #1631

Closed
pedro93 wants to merge 3 commits into
testcontainers:masterfrom
pedro93:bump-docker-java-3.1.4
Closed

Bump docker java 3.1.4#1631
pedro93 wants to merge 3 commits into
testcontainers:masterfrom
pedro93:bump-docker-java-3.1.4

Conversation

@pedro93

@pedro93 pedro93 commented Jul 21, 2019

Copy link
Copy Markdown

Bump to docker-java dependency to fix #1548

Replaces #1340 since I have no permissions to update that MR.

@bsideup

bsideup commented Jul 21, 2019

Copy link
Copy Markdown
Member

I am sorry that we have to bounce back with this one (again), but I see that the methods were added "one by one" instead of actually fixing the binary change.

To keep it clear what was actually changed, here is a link:
https://diff.revapi.org/?groupId=com.github.docker-java&artifactId=docker-java&old=3.1.0-rc-4&new=3.1.4

Just look for CreateContainerCmd:: (or Binary: BREAKING).

There are currently 38(!) binary breaking breaking changes between 3.1.0-rc-4 and 3.1.4 that we expect to be reverted, so that we can move forward with the upgrade.

@pedro93

pedro93 commented Jul 21, 2019

Copy link
Copy Markdown
Author

I am sorry that we have to bounce back with this one (again), but I see that the methods were added "one by one" instead of actually fixing the binary change.

That is a larger scope than what was originally said to me: #1340 (comment)

I do not have the context to perform those changes and know what the consequences would be.

Since I am not the maintainer of either repository nor have the insight to decide whether reverting the binary breaking changes is a good solution forward (reverting breaking changes would be contrary to the direction the docker-java repository is going by definition).

I shall then withdraw from trying to perform these changes.

Thank you for your time on this effort.

@pedro93 pedro93 closed this Jul 21, 2019
@bsideup

bsideup commented Jul 21, 2019

Copy link
Copy Markdown
Member

Hi @pedro93,

Thanks for the time you spent on it! I took over the effort and submitted docker-java/docker-java#1225

I'm in contact with Docker Java's maintainer and we hope that Testcontainers will receive the latest version of Docker Java very soon :)

@pedro93

pedro93 commented Jul 21, 2019

Copy link
Copy Markdown
Author

Looking forward to it, thank you @bsideup :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Container Startup Failure due to UnrecognizedPropertyException in docker config file

2 participants