This repository was archived by the owner on Sep 9, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 9, 2026. It is now read-only.
IOMixin for DocVec (to/from) #1330
Description
We want to support IO functionality in DocVec such as from/to json, csv, bytes, etc. For example, to/from json is needed to make it FastAPI-compatible.
However, we can not use the existing IOMixin here as the logic behind DocVec is different from DocList and we'd have to overwrite some functions.
Solution:
Create an abstract mixin containing functions that the two classes share, and for other functions create separate mixins inheriting from the abstract class
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
- Status
Activity
[-]IOMixin for DocArrayStacked[/-][+]IOMixin for Doc2Vec (to/from)[/+]JoanFM commentedon Apr 27, 2023
The description needs to be changed to Doc2Vec
JoanFM commentedon May 10, 2023
When implementing this, please make sure to habdle the case shown in #1490
[-]IOMixin for Doc2Vec (to/from)[/-][+]IOMixin for DocVec (to/from)[/+]JohannesMessner commentedon May 22, 2023
I am breaking this up into multiple PRs (will update the list as I go):
samsja commentedon Jun 2, 2023
lets not do too much abstraction here. There are no shared behavior between DocList and DocVec IO. Lets juts implement the function in both, no need for an abstract class until we can provide the same IO capacity for both