Skip to content

.NET SDK and package updates - #67

Merged
ForNeVeR merged 4 commits into
developfrom
feature/65-sdk-update
Jul 9, 2017
Merged

ForNeVeR merged 4 commits into
developfrom
feature/65-sdk-update

Conversation

@ForNeVeR

@ForNeVeR ForNeVeR commented Jul 9, 2017 •

Copy link
Copy Markdown
Member

Hereby I update .NET Core SDK to the latest stable version, and also update package versions to follow the recent security bulletins. The main visible change is that we migrate from (now obsolete) project.json to (restored in its rights) *.fsproj.

Also I've updated the npm-shrinkwrap configuration to match the latest npm 5 recommendations (and it should be backwards-compatible).

That will likely require us to update .NET Core version on our production site for the good (we're targeting netcoreapp1.1 now, that means we'll need .NET Core 1.1 installed).

Closes #65.

@ForNeVeR ForNeVeR self-assigned this Jul 9, 2017
@ForNeVeR
ForNeVeR requested a review from rexim July 9, 2017 05:42
@ForNeVeR

ForNeVeR commented Jul 9, 2017

Copy link
Copy Markdown
Member Author

Looks like something's wrong with our Appveyor integration; I'll reinitialize it.

@ForNeVeR

ForNeVeR commented Jul 9, 2017

Copy link
Copy Markdown
Member Author

I believe the problem with CI was because I recently cleaned up our organization integration list; hope it's fixed now. Note that Appveyor build is actually okay; it just cannot report the status here.

@rexim rexim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ForNeVeR
ForNeVeR merged commit 5cdc7e2 into develop Jul 9, 2017
@ForNeVeR

ForNeVeR commented Jul 9, 2017

Copy link
Copy Markdown
Member Author

Thanks for the review.

@ForNeVeR
ForNeVeR deleted the feature/65-sdk-update branch July 9, 2017 07:42
@ForNeVeR

ForNeVeR commented Jul 9, 2017

Copy link
Copy Markdown
Member Author

I had to do some maintainership commits to fix the build afterwards, but that's okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants