Skip to content

feat: add VS code notifications for workspace actions#111

Merged
Kira-Pilot merged 17 commits into
mainfrom
workspace-action-notifications/kira-pilot
Jun 27, 2023
Merged

feat: add VS code notifications for workspace actions#111
Kira-Pilot merged 17 commits into
mainfrom
workspace-action-notifications/kira-pilot

Conversation

@Kira-Pilot
Copy link
Copy Markdown
Member

@Kira-Pilot Kira-Pilot commented Jun 21, 2023

Opening this PR in place of #110 as this solution is a little cleaner.
This resolves coder/coder#7360
Screenshot 2023-06-22 at 12 33 03 PM

@Kira-Pilot Kira-Pilot requested review from code-asher and removed request for rodrimaia June 22, 2023 17:33
Comment thread src/WorkspaceAction.ts Outdated
Copy link
Copy Markdown
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love to see the # syntax at work.

I have not tried it out yet since when I build it tells me deleting_at does not exist. Do we need to update the coder dependency maybe?

Comment thread src/WorkspaceAction.ts
Comment thread src/WorkspaceAction.ts Outdated
Comment thread src/WorkspaceAction.ts Outdated
Comment thread src/WorkspaceAction.ts Outdated
Comment thread src/WorkspaceAction.ts
Comment thread src/WorkspaceAction.ts Outdated
Comment thread src/remote.ts Outdated
@Kira-Pilot
Copy link
Copy Markdown
Member Author

Kira-Pilot commented Jun 23, 2023

I have not tried it out yet since when I build it tells me deleting_at does not exist. Do we need to update the coder dependency maybe?

Done! Let me know if you still see that error.

Copy link
Copy Markdown
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

Comment thread src/WorkspaceAction.ts Outdated
Comment thread src/WorkspaceAction.ts Outdated
Comment thread src/WorkspaceAction.ts Outdated
Comment thread src/WorkspaceAction.ts Outdated
Comment thread src/remote.ts
@Kira-Pilot Kira-Pilot merged commit 713b2bd into main Jun 27, 2023
@Kira-Pilot Kira-Pilot deleted the workspace-action-notifications/kira-pilot branch June 27, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workspace actions: add VS Code notifications for workspace messaging

2 participants