feat: add VS code notifications for autostop#110
Closed
Kira-Pilot wants to merge 1 commit into
Closed
Conversation
Member
Kira-Pilot
commented
Jun 21, 2023
- part of the resolution for #7360
- the rest will follow after feat: automatically stop workspaces based on failure_ttl coder#7989 is merged up
rodrimaia
approved these changes
Jun 21, 2023
Contributor
rodrimaia
left a comment
There was a problem hiding this comment.
Approved. I am just not sure if every 5 seconds is not too frequent to keep calling getWorkspaces
Member
Author
Yeah, I feel the same way. It's the cadence we use in Dashboard so I went with it here. |
Member
Author
|
Closing in favor of #111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.