Skip to content

fix: don't close cached tailnet on pty close#8917

Merged
coadler merged 1 commit into
mainfrom
colin/pty-close-fix
Aug 4, 2023
Merged

fix: don't close cached tailnet on pty close#8917
coadler merged 1 commit into
mainfrom
colin/pty-close-fix

Conversation

@coadler
Copy link
Copy Markdown
Contributor

@coadler coadler commented Aug 4, 2023

Closes #8772

@coadler coadler added the hotfix label Aug 4, 2023
@coadler coadler self-assigned this Aug 4, 2023
cdr-bot[bot]
cdr-bot Bot approved these changes Aug 4, 2023
View reviewed changes
Copy link
Copy Markdown

@cdr-bot cdr-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@coadler coadler enabled auto-merge (squash) August 4, 2023 22:47
@coadler coadler merged commit eddaa77 into main Aug 4, 2023
@coadler coadler deleted the colin/pty-close-fix branch August 4, 2023 22:54
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@coadler coadler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

All Terminals Disconnect On Single Close

1 participant

@coadler