fix: don't close cached tailnet on pty close (#8917)

coadler · web-flow · commit eddaa7781d9f · 2023-08-04T22:54:27.000Z
diff --git a/coderd/workspaceapps/proxy.go b/coderd/workspaceapps/proxy.go
@@ -669,7 +669,6 @@ func (s *Server) workspaceAgentPTY(rw http.ResponseWriter, r *http.Request) {
 		return
 	}
 	defer release()
-	defer agentConn.Close()
 	log.Debug(ctx, "dialed workspace agent")
 	ptNetConn, err := agentConn.ReconnectingPTY(ctx, reconnect, uint16(height), uint16(width), r.URL.Query().Get("command"))
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -669,7 +669,6 @@ func (s Server) workspaceAgentPTY(rw http.ResponseWriter, r http.Request) {`
`669`	`669`	`return`
`670`	`670`	`}`
`671`	`671`	`defer release()`
`672`		`- defer agentConn.Close()`
`673`	`672`	`log.Debug(ctx, "dialed workspace agent")`
`674`	`673`	`ptNetConn, err := agentConn.ReconnectingPTY(ctx, reconnect, uint16(height), uint16(width), r.URL.Query().Get("command"))`
`675`	`674`	`if err != nil {`