chore: update example templates to use display_name#7001
Merged
Conversation
display_name to example templatesdisplay_name
mtojek
reviewed
Apr 4, 2023
Member
mtojek
left a comment
There was a problem hiding this comment.
Thanks for PR! Most comments refer to using display_name as a description, and for that we have a separate property.
Member
Author
|
@mtojek I have updated as per suggestions and moved the longer |
bpmct
approved these changes
Apr 7, 2023
Member
bpmct
left a comment
There was a problem hiding this comment.
Can you change all casing to title case?
e.g.
Docker Image->Docker imageHome Volume Size->Home volume size
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
mtojek
approved these changes
Apr 11, 2023
bpmct
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #6978
I validated all the templates with
terraform validate