Skip to content

chore: reduce docker examples#6849

Merged
bpmct merged 6 commits into
mainfrom
reduce-docker-examples
Apr 12, 2023
Merged

chore: reduce docker examples#6849
bpmct merged 6 commits into
mainfrom
reduce-docker-examples

Conversation

@bpmct
Copy link
Copy Markdown
Member

@bpmct bpmct commented Mar 28, 2023

fixes #4651

@bpmct bpmct requested a review from sharkymark March 28, 2023 15:01
kylecarbs
kylecarbs approved these changes Mar 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@bpmct bpmct enabled auto-merge (squash) March 28, 2023 15:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2023

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions Bot added the stale This issue is like stale bread. label Apr 5, 2023
@matifali
Copy link
Copy Markdown
Member

matifali commented Apr 5, 2023

the stale bot is being spammy.

@github-actions github-actions Bot removed the stale This issue is like stale bread. label Apr 6, 2023
@matifali
Copy link
Copy Markdown
Member

matifali commented Apr 7, 2023

Do you have any plans to merge this sooner? I am working on #7001 and its better if this merges before that @bpmct

@matifali
Copy link
Copy Markdown
Member

matifali commented Apr 7, 2023 •
edited
Loading

Let's keep only these 2.

  1. docker-with-dotfiles

    This contains docker

  2. docker-image-builds

    This demonstrates that Coder can build the images too.

Thoughts @bpmct ?

@bpmct
Copy link
Copy Markdown
Member Author

bpmct commented Apr 10, 2023

Sorry I missed these comments @matifali. I'd rather stick to one example for now.

@matifali
Copy link
Copy Markdown
Member

matifali commented Apr 11, 2023

Sounds fine.

@matifali
Copy link
Copy Markdown
Member

matifali commented Apr 11, 2023 •
edited
Loading

@bpmct
You need to update the test too,

coder/examples/examples_test.go

Line 39 in 63af4c6

tarData, err := examples.Archive("docker-image-builds")

@bpmct bpmct merged commit af24aea into main Apr 12, 2023
@bpmct bpmct deleted the reduce-docker-examples branch April 12, 2023 16:26
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

+1 more reviewer

@sharkymark sharkymark sharkymark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bpmct bpmct

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There are 4 example templates that basically do the same thing - confusing - remove one

4 participants

@bpmct @matifali @sharkymark @kylecarbs